-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump golang to 1.22 #2793
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
- Coverage 64.88% 58.88% -6.00%
==========================================
Files 121 162 +41
Lines 21393 27083 +5690
==========================================
+ Hits 13880 15948 +2068
- Misses 6643 10182 +3539
- Partials 870 953 +83 ☔ View full report in Codecov by Sentry. |
tools/src/helm-docs/go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/envoyproxy/gateway/tools/src/helm-docs | |||
|
|||
go 1.21 | |||
go 1.22 | |||
|
|||
require github.com/norwoodj/helm-docs v1.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe need bump to 1.13
@zirain crd-ref-docs cannot work in 1.22 .. |
can you raise this up on upstream? |
it's merged |
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
* chore: bump golang to 1.22 Signed-off-by: bitliu <bitliu@tencent.com> * fix: panic Signed-off-by: bitliu <bitliu@tencent.com> * bump crd-ref Signed-off-by: bitliu <bitliu@tencent.com> * make gen/testdata Signed-off-by: bitliu <bitliu@tencent.com> * fix docs failed Signed-off-by: bitliu <bitliu@tencent.com> * fix lint Signed-off-by: bitliu <bitliu@tencent.com> --------- Signed-off-by: bitliu <bitliu@tencent.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Bump go version